D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The trash ioslave currently handles:
  
  - working symlinks at the toplevel
  - broken symlinks at the toplevel
  - working symlinks in subdirectories
  
  but broken symlinks in a subdirectory gets lost.
  
  This is because subdirs are populated from a QDir::listEntries in the
  subdirectory folder, which by default filters out broken symlinks.
  
  It's important to list them so that we we restore the directory as
  otherwise we lose data. The symlink could become non-dead once files are
  restored.
  
  BUG: 400990

TEST PLAN
  Relevant unit test

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17021

AFFECTED FILES
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/tests/testtrash.h
  src/ioslaves/trash/trashimpl.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181119/7776afdf/attachment-0001.html>