D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

René J.V. Bertin noreply at phabricator.kde.org
Sun Nov 18 22:34:09 GMT 2018


rjvbb updated this revision to Diff 45759.
rjvbb added a comment.


  updated as suggested:
  
  - moves the context menu added stuff logic into a dedicated class (as an upbeat to possible future improvement)
  - caches the QMenu* to which actions were last added, and removes them from that menu when the next context menu is shown. This should be equivalent to removing the items on `contextMenuAboutToHide`.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16882?vs=45642&id=45759

REVISION DETAIL
  https://phabricator.kde.org/D16882

AFFECTED FILES
  kdevplatform/shell/textdocument.cpp
  kdevplatform/shell/textdocument.h

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181118/796b54db/attachment.html>


More information about the Kde-frameworks-devel mailing list