D16981: [kfilewidget] Ctrl+L returns editable URL navigator to breadcrumb mode only when it has focus

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, [Ctrl] + [+] toggles the location bar between editable and breadcrumb modes, which is nice. However, it does this even when the URL bar is not focused, which can lead to times when you want to enter a path and instead accidentally make it un-editable, oops.
  
  This patch refines the behavior so that it only toggles the mode when the location bar has focus. This brings the behavior into 100% consistency with Dolphin, once D16980 <https://phabricator.kde.org/D16980> lands.

TEST PLAN
  - Compile and deploy
  - Open a file open/save dialog and make the location bar be breadcrumbs
  - Hit [Ctrl] + [L] twice in a row -> location field turns to being in breadcrumb mode. Focus is correctly returned to the main view.
  - Hit [Ctrl] + [L], move focus elsewhere, then hit [Ctrl] + [L] again -> Location bar is editable and focused.

REPOSITORY
  R241 KIO

BRANCH
  more-sophisticated-ctrl-l-behavior (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16981

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181118/bde8cccc/attachment.html>