firewall-applet icons break breeze auto tests

[Noah Davis]

On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote:
> El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va 
escriure:
> > On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote:
> > > Hi Noah,
> > > 
> > > At the moment breeze-icons auto tests are failing with this error (both
> > > for
> > > icons and icons-dark)
> > > 
> > > The following icons are not available in a scalable directory:
> > >   firewall-applet-shields_up
> > >   firewall-applet-panic
> > >   firewall-applet
> > >   firewall-applet-error
> > > 
> > > This is because the test makes sure that all icons present in a "Fixed
> > > size
> > > folder" (for apps 16, 22, 32) should be available in a "Scalable size
> > > folder" (for apps 48).
> > > 
> > > Could you please work in fixing that so the auto test starts passing
> > > again?
> > > 
> > > Cheers,
> > > 
> > >   Albert
> > 
> > Hi, I was notified about that on the Phabricator diff after it was landed
> > (https://phabricator.kde.org/D11880), but I didn't know what the error
> > meant or what to do about it. I would be glad to fix it if you or someone
> > else could help me figure out what to do.
> 
> I did tell you exactly what is the problem, didn't I?
> 
> *************
> This is because the test makes sure that all icons present in a "Fixed size
> folder" (for apps 16, 22, 32) should be available in a "Scalable size
> folder" (for apps 48).
> *************
> 
> Cheers,
>   Albert

I think I just don't understand the system. I think what's tripping me up is 
that some icon themes use a folder called "scalable" for SVGs and the other 
folders are used for PNGs, but Breeze doesn't do that because it only uses 
SVGs and SVGs are naturally scalable.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181117/7a0f3f54/attachment.sig>