D16885: Delete the correct item in removeDesktop

David Edmundson noreply at phabricator.kde.org
Wed Nov 14 23:55:21 GMT 2018


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QList::erase will move the data underneath where the iterator is
  pointing, we want to delete the entry we're about to remove from the
  list.

TEST PLAN
  Relevant tests now behave better

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16885

AFFECTED FILES
  src/server/plasmavirtualdesktop_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181114/ff6d5a18/attachment.html>


More information about the Kde-frameworks-devel mailing list