D16878: Resolve symlinks in exclude folders

Igor Poboiko noreply at phabricator.kde.org
Wed Nov 14 15:14:56 GMT 2018


poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  Assume user has `~/stuff` folder, that is symlinked to i.e. `/storage/stuff`.
  User don't want it to be indexed, so he adds `~/stuff` in the KCM. However, this entry gets silently ignored when indexer
  runs over `/storage` (trivially because it does not match `~/stuff`), resulting to excluded folder being indexed.
  
  Instead I propose to resolve symlinks right when loading exclude folder list from config.

TEST PLAN
  It compiles, it seems to be working

REPOSITORY
  R293 Baloo

BRANCH
  resolve-exclude-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16878

AFFECTED FILES
  src/file/fileindexerconfig.cpp

To: poboiko, #frameworks, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181114/96acf616/attachment.html>


More information about the Kde-frameworks-devel mailing list