D16857: Do not disconnect all StorageAccess signals when unmounting

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Nov 13 22:43:01 GMT 2018


bruns added a comment.


  I think this is correct, but the summary can be improved a little bit.
  
  The problem is caused by the fact device interfaces returned by Solid (e.g. `item->device().as<Solid::StorageAccess>()`) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the same interface for a device will return the same address every time.
  
  If the interface is used used in multiple places, calling disconnect on the interface address disconnects the signals for all users.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16857

To: thsurrel, #dolphin, #frameworks, bruns
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181113/677cd505/attachment.html>


More information about the Kde-frameworks-devel mailing list