D16733: Capture package metadata before install start

David Edmundson noreply at phabricator.kde.org
Wed Nov 7 12:21:34 GMT 2018


davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KPackage (despite being supposedly internally shared) is not kept as a
  strong reference inside PackageJob. Potentially it could go out of scope
  before a job ends.
  
  The signals to emit changes relied on the package. This patch captures
  relevant metadata at the start of the install.
  
  noCrashOnAsyncInstall test now passes again

TEST PLAN
  Ran test

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16733

AFFECTED FILES
  src/kpackage/private/packagejob.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181107/288c5cc9/attachment.html>


More information about the Kde-frameworks-devel mailing list