D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added reviewers: broulik, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.


  Great, thanks! This work well; I just have a few comments, listed below.
  
  To update this diff without accidentally creating a new one, make sure you're on the `permeability` branch in your `kunitconversion` repo, then make your change and run `arc diff`. It shouldn't try to create a new one.

INLINE COMMENTS

> unit.h:333
> +    MiliDarcy,
> +    PermeabilitySquareMicrometer
>  };

Can you add `/** @since 5.53 */` above each new one, following the pattern?

> volume.cpp:452
>  
> +    addCommonUnit(CustomUnit(VolumeCategory, OilBarrel, 0.158987294,
> +                             i18nc("volume unit symbol", "bbl"),

I'm not sure this should be marked as a common unit. Because it is, I now get oil barrels listed first when I have KRunner convert something like "2 cups" or "8 liters".

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181105/0976ad9b/attachment.html>