D16678: Fix root disk icon change so that it doesn't erroneously change other icons

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> udisksdevice.cpp:874
> +{
> +    if (queryDeviceInterface(Solid::DeviceInterface::StorageAccess)) {
> +        const UDisks2::StorageAccess accessIface(const_cast<Device *>(this));

Can you check whether using `isStorageAccess()` is more desirable/performant?

> udisksdevice.h:84
>      bool isEncryptedCleartext() const;
> +    bool isRoot() const; // @since 5.53
>      bool isSwap() const;

This isn't public API, you don't need this comment, also perhaps `isRootVolume`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16678

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181105/d4ed6fb5/attachment-0001.html>