D16678: Fix root disk icon change so that it doesn't erroneously change other icons
Nathaniel Graham
noreply at phabricator.kde.org
Mon Nov 5 04:46:07 GMT 2018
ngraham created this revision.
ngraham added reviewers: bruns, broulik, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
I committed D16653 <https://phabricator.kde.org/D16653> too soon without enough testing, because it had the effect of applying the default `drive-harddisk` icon to more device types. Oops. Sorry about that. :(
This patch fixes the problem, and is better tested.
TEST PLAN
Other device types are not affected:
[image goes here]
REPOSITORY
R245 Solid
BRANCH
fix-root-icon-change (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D16678
AFFECTED FILES
src/solid/devices/backends/udisks2/udisksdevice.cpp
src/solid/devices/backends/udisks2/udisksdevice.h
To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181105/8e7f0952/attachment.html>
More information about the Kde-frameworks-devel
mailing list