D16676: [server] Put (de-)activate, en-/disable callbacks in child classes

Roman Gilg noreply at phabricator.kde.org
Mon Nov 5 01:33:06 GMT 2018


romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The activate/deactivate and enable/disable callback functionality was in the
  TextInputInterface::Private interface, but these calls are each specific to v0
  and v2 of the protocol.
  
  Since v3 will have again a different function signature, put all the callbacks
  and their helper functions in the protocol version specific child classes.

TEST PLAN
  Compiles, runs.

REPOSITORY
  R127 KWayland

BRANCH
  textInputActivateEnable

REVISION DETAIL
  https://phabricator.kde.org/D16676

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181105/8c414f9e/attachment.html>


More information about the Kde-frameworks-devel mailing list