D16643: Correct m_enabled on DragMove
trmdi
noreply at phabricator.kde.org
Sat Nov 3 17:40:33 GMT 2018
trmdi created this revision.
trmdi added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trmdi requested review of this revision.
REVISION SUMMARY
- `m_enabled` could change while moving.
- Don't call `setAccepted(false)` wrongly if `event->pos() == m_oldDragMovePo`
BUG: 396011
TEST PLAN
- Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too difficult -> fixed
- Drag an icon on Desktop (Folder view layout) from one place to another one -> too difficult -> fixed
- Add widgets to the Plasma panel -> too difficult -> fixed
- Drag a file from Dolphin -> Desktop (Folder view layout) -> still easy
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D16643
AFFECTED FILES
src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp
To: trmdi, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181103/c6393902/attachment.html>
More information about the Kde-frameworks-devel
mailing list