D16591: [XmlExtractor] Use QXmlStreamReader for better performance

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Nov 3 03:16:04 GMT 2018


bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> apol wrote in xmlextractortest.cpp:70
> Won't this break any use?

Previously, the last element was "foo_bar__", now it is "foo_bar_".
SimpleExtractionResult::append(text) adds a space after the inserted text after each call.
If there is something sensitive to multiple whitespaces, we have a problem - but I really doubt it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181103/0c8a07d5/attachment.html>


More information about the Kde-frameworks-devel mailing list