D16618: add explicit to constructors

Matthieu Gallien noreply at phabricator.kde.org
Fri Nov 2 21:05:50 GMT 2018


mgallien added inline comments.

INLINE COMMENTS

> simpleextractionresult.h:42
>  public:
> -    SimpleExtractionResult(const QString& url, const QString& mimetype = QString(), const Flags& flags = ExtractEverything);
> +    explicit SimpleExtractionResult(const QString& url, const QString& mimetype = QString(), const Flags& flags = ExtractEverything);
>      SimpleExtractionResult(const SimpleExtractionResult& rhs);

Given this class is exported, is this binary compatible ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16618

To: astippich, #frameworks, bruns
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/52ed3c6f/attachment.html>


More information about the Kde-frameworks-devel mailing list