D16591: [XmlExtractor] Use QXmlStreamReader for better performance

Alexander Stippich noreply at phabricator.kde.org
Fri Nov 2 20:14:05 GMT 2018


astippich added inline comments.

INLINE COMMENTS

> xmlextractortest.cpp:70
>      QCOMPARE(result.text().leftRef(8), content.leftRef(8));
> -    QCOMPARE(result.text().size(), 1 + 8 * count);
> +    QCOMPARE(result.text().size(), 8 * count);
>  

why is there a difference?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/7a0a7939/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list