D16434: Fix keyboard layout change notifications

[Fabian Vogt]

fvogt marked 2 inline comments as done.
fvogt added inline comments.

INLINE COMMENTS

> romangg wrote in kglobalaccel_x11.cpp:96
> Before there was a check to `QX11Info::isPlatformX11()`. Probably we don't need the check, but did you test on Wayland?

The plugin is only loaded if the Qt platform is xcb, so the connection can never be null in that case.
I'll add a `Q_ASSERT` though.

> romangg wrote in kglobalaccel_x11.cpp:220
>   case m_xkb_first_event:
>       if (m_xkb_first_event) {
>           ...
>       }
>   default:
>       return false;
> 
> Or directly do the switching on `responseType` with if-else statements.

case m_xkb_first_event:

Is not valid C++ - case expressions have to be constants.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16434

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/ed3b3768/attachment.html>