D16583: use qlatin1 for embedded image extractor

[Stefan Brüns]

bruns added a comment.


  Please use proper Capitalization in the Summary.

INLINE COMMENTS

> embeddedimagedata.cpp:175
>          TagLib::List<TagLib::FLAC::Picture *> lstPic;
> -        if (mimeType == QStringLiteral("audio/ogg") || mimeType == QStringLiteral("audio/x-vorbis+ogg")) {
> +        if (mimeType == QLatin1String("audio/ogg") || mimeType == QLatin1String("audio/x-vorbis+ogg")) {
>              TagLib::Ogg::Vorbis::File oggFile(&stream, true);

can you add a line break here and below? Also add parentheses, like for "audio/mpeg" above.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16583

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/0966e0b4/attachment-0001.html>