D16490: [KFileMetaData] Add unittest for XML extractor

[Stefan Brüns]

bruns added a comment.


  In D16490#351935 <https://phabricator.kde.org/D16490#351935>, @astippich wrote:
  
  > In D16490#351799 <https://phabricator.kde.org/D16490#351799>, @bruns wrote:
  >
  > > In D16490#351662 <https://phabricator.kde.org/D16490#351662>, @astippich wrote:
  > >
  > > > Only one minor thing: please also check that the mimetype is in the list of supported mimetypes
  > >
  > >
  > > This can actually happen and is completely valid, due to mimetype inheritance.
  > >
  > > So the check would be `for supported in supportedMimetypes { if QMimeType(input->mimeType()).inherits(supported) return true; }; return false`. But this is already done from the calling code ...
  >
  >
  > Hmmm, I don't understand. When I change the code to return an empty stringlist of supported mimetypes for the xmlextractor, the tests still pass.
  >  This should imho be covered by the tests.
  
  
  This is one level above these tests. The surrounding code ensures the right extractor is called for each file, see `ExtractorCollection::fetchExtractors(...)`.
  
  These are unit tests. The test itself is responsible to call an extractor with a suitable file and a matching mimetype.
  
  What you are calling for are system tests.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/05ec61cc/attachment.html>