D13223: Set kcm context property on the correct context
David Edmundson
noreply at phabricator.kde.org
Wed May 30 20:55:20 UTC 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
One code path of kdeclarative uses a shared engine.
If we have a shared engine we have one engine with a root context and
several sub contexts. In this case it's important to set properties on
the context of our QQmlObject, not the shared root context of the
engine.
TEST PLAN
I didn't see it affecting anything as one tends to only open one KCM at a time
Loaded the fonts KCM in system settings
Loaded the volume KCM via the plasma-pa applet
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13223
AFFECTED FILES
src/quickaddons/configmodule.cpp
To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180530/5d4ef8ec/attachment.html>
More information about the Kde-frameworks-devel
mailing list