D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  In some cases, when rendering frame svg background, measures & margins
  do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
  but the bottom border is disabled. This causes visual artifacts like this
  
  <%= image %>
  
  There are several approaches to fix this problem:
  
  - Rewrite the `contentGeometry` method, so it takes into account whether the left/top/right/bottom border is enabled.
  
  - Or, call `updateSizes` before rendering frame svg background.
  
  I took the latter approach in this diff.
  
  Just for reference, this is "after"
  
  <%= image %>
  
  BUG: 382324
  BUG: 390632
  BUG: 391659

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-framesvg-contentrect

REVISION DETAIL
  https://phabricator.kde.org/D13215

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180530/de8ceecc/attachment.html>