bic in kactivities

Christoph Feck cfeck at kde.org
Wed May 30 09:48:41 UTC 2018


On 30.05.2018 10:13, Harald Sitter wrote:
> Salut!
>
> https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1
>
> It appears to me that this is a binary incompatible change.
>
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
>> You cannot...For existing functions of any type:change its signature. This includes:changing any of the types of the arguments in the parameter list, including changing the const/volatile qualifiers of the existing parameters (instead, add a new method)

Worse: The commit does not only add a 'const', but converts the argument 
from an object to a reference to the object.


More information about the Kde-frameworks-devel mailing list