D12233: Avoid manipulation of lists with quadratic complexity

[Dominik Haumann]

dhaumann added a comment.


  I would give a ship-it - but maybe another review would be good? @ngraham maybe?

INLINE COMMENTS

> bruns wrote in pendingfilequeue.cpp:69
> GCC generates identical code for both ...

Did you check? This is certainly correct for i++ if i is an int. But for iterators, which are classes, this is often not the case, but I may be wrong here. In any case, this is a minor nitpick you can simply ignore, so please go ahead :-)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh
Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180530/a7807348/attachment.html>