D12047: Avoid crash when reading corrupt data from document terms db

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue May 29 12:19:43 UTC 2018


bruns added a comment.


  In D12047#269976 <https://phabricator.kde.org/D12047#269976>, @dhaumann wrote:
  
  > If the format is really such that a term must appear before any Suffix, then this patch is already better that before.
  >
  > Could it happen to have e.g.: a\0b1c1
  >
  > If so, this code would extend the Suffix b with Suffix c. Would that be correct? Or can that never happen? Or should c be a Suffix for a? If so, this code should be improved.
  
  
  a\x00b\x01c\x01 would be decoded as "a", "ab", "abc".
  
  "the", "their", "theirs", "there" is encoded as "the\x00ir\x01s\x01there\x00".

REPOSITORY
  R293 Baloo

BRANCH
  b392878_avoid_docterms_decode_crash

REVISION DETAIL
  https://phabricator.kde.org/D12047

To: bruns, #baloo, michaelh, ngraham, #frameworks, dhaumann
Cc: dhaumann, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180529/68cafb94/attachment.html>


More information about the Kde-frameworks-devel mailing list