D12233: Avoid manipulation of lists with quadratic complexity

[Dominik Haumann]

dhaumann added a comment.


  Looks good to me.

INLINE COMMENTS

> pendingfilequeue.cpp:69
> +        const auto droppedFilesBegin = std::partition(m_cache.begin(), end, keepFile);
> +        for (auto it = droppedFilesBegin; it != end; it++) {
> +            m_pendingFiles.remove(it->path());

++it is faster.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh
Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180529/0c816082/attachment-0001.html>