D12291: Accept file descriptor only from root owned process

Oswald Buddenhagen noreply at phabricator.kde.org
Sun May 27 11:50:40 UTC 2018


ossi added inline comments.

INLINE COMMENTS

> fdreceiver.cpp:89
> +#else
> +#warning Cannot get socket credentials!
> +#endif

i wonder whether that shouldn't come with an unconditional acceptConnection = true; then - now the compilation succeeds, but it will fail to operate. given that the whole feature is redundant with moving the socket to a safe place (something you really should mention in the commit message), this seems like a rather pointless limitation.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12291

To: chinmoyr, #frameworks, dfaure, ossi
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180527/dd1d38cc/attachment.html>


More information about the Kde-frameworks-devel mailing list