D12820: Add KWayland virtual desktop protocol

Marco Martin noreply at phabricator.kde.org
Thu May 24 09:24:10 UTC 2018


mart added inline comments.

INLINE COMMENTS

> graesslin wrote in org_kde_plasma_virtual_desktop.xml:45
> Please note that your quick way would not work. Activities are disabled in KWin Wayland and I don't see them getting enabled again. Activities resulted in hard freezes several times and I don't trust them due to that. As maintainer I would need very convincing arguments on why activities won't break KWin again. Due to the fact that kamd speaks both dbus and windowing protocol I don't see a chance that KWin can rely on it.
> 
> Due to the fact that activities used to block KWin it's an area which is completely not ported to Wayland yet. A Wayland window cannot be put on an activity. So this would require a significant amount of work. This also doesn't match anything we have in KWin to move forward. Activities have been in an unmaintained state since the start and the code is in a really bad state. None of the core KWin developers have touched it in the last year's. It's just a bad copy and paste of virtual desktops without any understanding of the domain. I do not want to see any future code being based on that. In KWin we started to evolve virtual desktops, so that in future it would be possible to implement the feature set of activities in virtual desktops. But for the time being it would mean X11 identifiers, that is numerical desktops.
> 
> I put know out an interesting question: do we need layouts?

well, i'm not really talking about the current activity code in kwin, but just a 1:1 mapping for the user, for which i was expecting different code to be written.
if the 1:1 mapping happens on kwin side, or on plasma/kactivities side trying to sync itself to desktops (in this case the protocol would need also adddesktop/removedesktop methods, then kwin wouldn't need to use kactivities directly, the sync can be done client side.

but i don't want the user to see any difference anymore for the two concepts anymore.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180524/356526f8/attachment.html>


More information about the Kde-frameworks-devel mailing list