D13083: Respect custom directory icons in iconNameForURL()

Kai Uwe Broulik noreply at phabricator.kde.org
Thu May 24 07:36:19 UTC 2018


broulik added a comment.


  This still has the issue of blocking if the contents is an unavailable nfs share of some sort.

INLINE COMMENTS

> global.cpp:377
> +        // Check to see if the folder has a custom icon
> +        QString customIcon = iconFromDirectoryFile(url.toLocalFile());
> +        if (!customIcon.isEmpty()) {

You do `toLocalFile()` here, so move that also into the `isLocalFile()` branch

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13083

To: ngraham, #frameworks, apol, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180524/593767aa/attachment.html>


More information about the Kde-frameworks-devel mailing list