D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed May 23 13:54:12 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> kfileitem.cpp:1248
> +{
> +    return d->m_hash < other.d->m_hash;
> +}

This is incomplete for two cases:

1. Same URL
2. Hash collision

> kfileitem.h:490
> +    /**
> +     * Returns -1 if other's URL is greater, 0 if == and 1 if less than (as in String comparations).
> +     * @since 5.47

The description does not match the implementation ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180523/6dc853ca/attachment.html>


More information about the Kde-frameworks-devel mailing list