D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

Roman Gilg noreply at phabricator.kde.org
Tue May 22 11:38:50 UTC 2018


romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Dialog might try to set PlasmaShellSurface before Wayland Server has sent
  the PlasmaShell proxy to DialogShadows. This can be observed with KWin's
  TabBox.
  
  Connect to DialogShadows new signal waylandPlasmaShellInterfaceAnnounced
  in case the PlasmaShell interface has not yet been announced.

TEST PLAN
  Manual debug statement shows that DialogPrivate::shellSurface is set.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  waitOnSetupWayland

REVISION DETAIL
  https://phabricator.kde.org/D13037

AFFECTED FILES
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180522/71126baa/attachment.html>


More information about the Kde-frameworks-devel mailing list