D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265235 <https://phabricator.kde.org/D12986#265235>, @rkflx wrote:
  
  > In D12986#265231 <https://phabricator.kde.org/D12986#265231>, @ngraham wrote:
  >
  > > Yeah, that makes sense. Suggestions welcome, of course. Is this any better?
  > >  F5859259: After 2.png <https://phabricator.kde.org/F5859259>
  >
  >
  > Hm, I think after the checkbox there should some sort of sentence, with a noun in front:
  >
  >   Cleanup: [ ] Automatically empty after 7 days
  >   
  >
  >  ---
  >
  > In D12986#265232 <https://phabricator.kde.org/D12986#265232>, @abetts wrote:
  >
  > > Warn me - when limit is reached
  >
  >
  > Putting the combobox in front would violate the HIG, wouldn't it?
  >
  > @ngraham Please change your language to both Greek and German, and notice the width of the label as well as the width of the combobox. Your current proposal will blow up the width of the dialog massively, and create a huge amount of whitespace on the left as well.
  >
  > Perhaps you need something like this:
  >
  >   Noun: Explanations are good
  >         Combobox
  >   
  >
  > Alternatively:
  >
  >   Noun: ( ) Option 1
  >         ( ) Option 2
  >         ( ) Option 3
  
  
  Much better!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180520/3a540929/attachment.html>