D12955: [KCModuleQml] Ignore disabled controls when tabbing

Kai Uwe Broulik noreply at phabricator.kde.org
Fri May 18 07:57:22 UTC 2018


broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Whether an item is enabled or not doesn't seem to affect its `focusPolicy` or position in the focus chain.
  Explicitly ignore disabled controls and move to the next.
  Fixes being unable to tab out of a QML KCM when the "Help" button (typically next control after the view in System Settings) is disabled

TEST PLAN
  Successfully tabbed in and ouf of desktop theme KCM in both directions and never got stuck

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D12955

AFFECTED FILES
  src/kcmoduleqml.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180518/c8a274cd/attachment.html>


More information about the Kde-frameworks-devel mailing list