D12932: handle string lists as input

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> result.cpp:90
> +        bool shouldBeIndexed = KFileMetaData::PropertyInfo(property).shouldBeIndexed();
> +        for (const auto& val : value.toStringList())
> +        {

`const auto list = value.toStringList();`, to avoid detach.

> result.cpp:93
> +            if (val.isEmpty())
> +                return;
> +            m_termGen.indexText(val, prefix);

`continue;`, you don't want to drop the remaining list entries

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180516/4545a9bc/attachment.html>