D12896: Add Telegram plugin

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue May 15 16:54:30 UTC 2018


apol added inline comments.

INLINE COMMENTS

> telegramplugin.cpp:53
> +            foreach(const QJsonValue& val, array) {
> +                ret += toPath(val.toString());
> +            }

toUrl().toLocalFile().

Also I would Check if(url.isLocalFile()).

> telegramplugin.cpp:61
> +            QProcess* process = new QProcess(this);
> +            process->setProgram(QStringLiteral("telegram-desktop"));
> +            QJsonArray urlsJson = data().value(QStringLiteral("urls")).toArray();

Instead of finding the program, we could execute using `org.telegram.desktop.desktop`, it would allow it to work even if it's installed from appimage/flatpak.

I'm not sure how this would work without bumping the tier.

> telegramplugin.cpp:63
> +            QJsonArray urlsJson = data().value(QStringLiteral("urls")).toArray();
> +            qCDebug(PLUGIN_TELEGRAM()) << "Foo" << urlsJson;
> +            process->setArguments(QStringList(QStringLiteral("-sendpath")) << arrayToList(urlsJson));

Fix or remove debug message.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180515/4feff2e5/attachment.html>


More information about the Kde-frameworks-devel mailing list