kfilemetadata compile failure

[Matthieu Gallien]

On lundi 14 mai 2018 19:57:58 CEST Albert Astals Cid wrote:
> El diumenge, 13 de maig de 2018, a les 23:15:56 CEST, Matthieu Gallien va
> 
> escriure:
> > On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote:
> > > El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell
> > > va
> > > 
> > > escriure:
> > > > On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote:
> > > > > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote:
> > > > > > kfilemetadata does not compile in KDE neon from git master
> > > > > > currently
> > > > > > 
> > > > > > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
> > > > > > ‘AVCodecParameters’ does not name a type
> > > > > > 12:27:35          const AVCodecParameters* codec =
> > > > > > stream->codecpar;
> > > > > > 
> > > > > > https://build.neon.kde.org/job/xenial_unstable_kde_kfilemetadata_b
> > > > > > in
> > > > > > _a
> > > > > > md
> > > > > > 64/1 45/console
> > > > > 
> > > > > Raised a concern on the resp. Phab Diff (to ping the responsible
> > 
> > people):
> > > > >   https://phabricator.kde.org/R286:037208a787e0c2412ab616ff1573c323a
> > > > >   23
> > > > >   46
> > > > >   d2
> > > > >   d
> > > 
> > > If phabricator had worked i would have read that.
> > > 
> > > > This compile failure is still in the shortly to be released
> > > > kfilemetadata
> > > > tar
> > > > 
> > > > https://build.neon.kde.org/job/xenial_release_kde_kfilemetadata_bin_am
> > > > d6
> > > > 4/
> > > > 37 /console 14:11:40
> > > > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
> > > > ‘AVCodecParameters’ does not name a type 14:11:40          const
> > > > AVCodecParameters* codec = stream->codecpar;
> > > 
> > > your avcodec is too old, get a new one.
> > > 
> > > But yes, either the commit should be reverted or the the avcodec cmake
> > > requirement increased.
> > 
> > Sorry, I have completely forgotten to check that during the review. This
> > is
> > my fault.
> > What is the best way to revert for the v5.46.0 release and bump the
> > dependency on master ?
> 
> 5.46.0 was already released, so nothing we can do "to fix it".

I was meaning to have a fix on top of v5.46.0 that may be released as a 
v5.46.1 if needed.

> 
> Cheers,
>   Albert
> 
> > > Cheers,
> > > 
> > >   Albert
> > >   
> > > > Jonathan

phabricator seems to be down. Please find attached a patch to add a check for 
version 3.1 of ffmpeg that has the needed API to fix the build failure.

Sorry again for the time lost by everybody on this issue.

Best regards

--
Matthieu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-check-that-ffmpeg-is-at-least-version-3.1-that-intro.patch
Type: text/x-patch
Size: 927 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180514/d0c05bb2/attachment.bin>