D12734: Scale up folder icon before creating preview overlays

Peter Mühlenpfordt noreply at phabricator.kde.org
Mon May 14 15:30:39 UTC 2018


muhlenpfordt added a comment.


  In D12734#259515 <https://phabricator.kde.org/D12734#259515>, @rkflx wrote:
  
  > Nevertheless, let's check the impact of this again: https://lxr.kde.org/ident?_i=thumbForDirectory
  >  Does not look too critical to me, and we probably tested most of the code paths.
  
  
  The normal KDE file dialog (e.g. Kate > File > Open...) also uses the upscaled preview without any problems.
  I searched for (`KIO::`)`filePreview` on lxr which gives a couple of results. They all use similar methods to handle the icons and I can't spot anything unsual related to the returned size.
  Ok to commit?

REPOSITORY
  R320 KIO Extras

BRANCH
  scale-up-folder-icon (branched from Applications/18.04)

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180514/4fcea92c/attachment.html>


More information about the Kde-frameworks-devel mailing list