D12696: Use the new uds implementation

[David Faure]

dfaure added a comment.


  Starting to look good ;-)

INLINE COMMENTS

> udsentry.h:143
>      /**
>       * insert field with string value
>       * @param field numeric field id

The old insert() should be documented that it asserts if the entry already exists, and that one should use replace() instead. This will minimize surprises in case anyone hits this.

> udsentry.h:319
>      QSharedDataPointer<UDSEntryPrivate> d;
> +    friend KIOCORE_EXPORT QDataStream& (::operator<<) (QDataStream &s, const KIO::UDSEntry &a);
> +    friend KIOCORE_EXPORT QDataStream& (::operator>>) (QDataStream &s, KIO::UDSEntry &a);

heh, nice syntax ;-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180509/fc9dc387/attachment-0001.html>