D12756: [KDateTable] Use a more visible red color

Nathaniel Graham noreply at phabricator.kde.org
Tue May 8 14:26:56 UTC 2018


ngraham created this revision.
ngraham added reviewers: Frameworks, cfeck.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  When I started work on this, I first wrote a conditional lightness check that switched between `Qt::red` and `Qt::darkRed` depending on the theme's window background color. That worked, but then noticed that `Qt::darkRed` isn't all that visible for Breeze light in the first place. `Qt::red` looks better and is more visible for both of them, so let's just use that instead!
  
  BUG: 389075
  FIXED-IN 5.47

TEST PLAN
  Breeze Light:
  
  Breeze Dark:

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  kdatetable-more-visible-red-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12756

AFFECTED FILES
  src/kdatetable.cpp

To: ngraham, #frameworks, cfeck
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180508/9420849f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list