D12744: Add null pointer check when creating SocketAddress

David Faure noreply at phabricator.kde.org
Tue May 8 13:52:37 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in fdreceiver.cpp:36
> print out `m_path.toLocal8Bit()` here?

Possibly nitpicking, but toStdString converts to utf8 while toLocal8Bit() is what's used for SocketAddress and what's recommended for terminal output as well. If toLocal8Bit() doesn't compile, then you need m_path.toLocal8Bit().constData(). Or the short version for a cout/cerr statement:

  << qPrintable(m_path) << std::endl;

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12744

To: chinmoyr, dfaure, ossi
Cc: #frameworks, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180508/8f4a757f/attachment.html>


More information about the Kde-frameworks-devel mailing list