D12734: Scale up folder icon before creating preview overlays

Peter Mühlenpfordt noreply at phabricator.kde.org
Tue May 8 05:41:43 UTC 2018


muhlenpfordt added a comment.


  In D12734#259336 <https://phabricator.kde.org/D12734#259336>, @rkflx wrote:
  
  > +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch (sans the `qMax`) here, so perhaps wait until the end of the week for any other opinions before committing.
  
  
  I did nearly the same in my initial search, except for the separate `extent` var. So, two ideas leading to the same code can't be wrong.  ;)  But sure, I'll wait until next week.
  
  > BTW, any reason you are targetting `master` only?
  
  I wanted to be careful here since I'm a bit afraid of changing library functions. If you think it's ok for `Applications/18.04` I'll rebase it.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180508/9289d83d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list