D12696: Use the new uds implementation

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon May 7 15:36:53 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> udsentry.cpp:132
> +    }
> +    static void save(QDataStream &s, const UDSEntry &a)
> +    {

Is there a reason to define the methods inside the class declaration? The diff would be significantly smaller if you kept the definition separate.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: bruns, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180507/193e3c08/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list