D12728: KFileItemActions: fallback to default mimetype when selecting only files

Elvis Angelaccio noreply at phabricator.kde.org
Sun May 6 18:34:15 UTC 2018


elvisangelaccio created this revision.
elvisangelaccio added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  KFileItemListProperties::mimeType() returns an empty string if the
  selected files have different types, but KMimeTypeTrader does not
  support empty mimetypes as query argument.
  
  This causes the following warning
  
    KMimeTypeTrader: mimeType "" not found
  
  and breaks the bluedevil's 'Send via Bluetooth' plugin.
  
  If we know the user selected only files, we can use the default mimetype
  as fallback.
  
  BUG: 393710
  FIXED-IN: 5.47

TEST PLAN
  Select two files with different extension and check 'Send via Bluetooth' is in the Dolphin context menu.

REPOSITORY
  R241 KIO

BRANCH
  kfileitemactions-emptymime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12728

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: elvisangelaccio, #frameworks, dfaure
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180506/b583307b/attachment.html>


More information about the Kde-frameworks-devel mailing list