D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi requested changes to this revision.
ossi added a comment.
This revision now requires changes to proceed.


  note that there are also unaddressed comments from previous rounds.

INLINE COMMENTS

> sharefd_p.h:50
>      {
> -        return reinterpret_cast<const sockaddr*>(&addr);
> +        return (addr.sun_path[0] || addr.sun_path[1]) ? reinterpret_cast<const sockaddr*>(&addr) : nullptr;
>      }

given that the linux-specific part is already gone by now, checking [1] doesn't make sense any more.

> sharefd_p.h:59
> +        a.sun_family = AF_UNIX;
> +        const QByteArray finalPath = "/tmp/" + path;
> +        const size_t pathSize = finalPath.size();

wait a sec, didn't an ancestor commit change that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks, dfaure, ossi
Cc: ossi, thiago, dfaure, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180506/71e93ac1/attachment-0001.html>