D12511: optimization of KTextEditor::DocumentPrivate::views()

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  lgtm in general, but codewise can be improved

INLINE COMMENTS

> katedocument.cpp:2835
>      m_views.insert(view, static_cast<KTextEditor::ViewPrivate *>(view));
> +    m_viewsCache = m_views.keys();
>  

just add the view, cf. the contains check above. no need to rebuild the full list here all the time

> katedocument.cpp:2852
>      m_views.remove(view);
> +    m_viewsCache = m_views.keys();
>  

dito, just remove

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12511

To: jtamate, #kate, cullmann, mwolff
Cc: mwolff, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180504/6c5d17fa/attachment.html>