D12662: Add InlineNoteInterface

Sven Brauch noreply at phabricator.kde.org
Thu May 3 22:28:05 UTC 2018


brauch added a comment.


  Oh, heh, yes it does. It's just your docstring which says otherwise ("is an interface for the View"), and that's what I looked at at that time. That should be changed. ;)
  
  I think the question is less what you need and more what it is supposed to do semantically. Do you add annotations to a *document*, or do you add them to a specific *view* of that document (remember that there can be more than one view of a document, even visible at once, e.g. splitview)? I think you can find arguments for both, but I feel like the document variant (as you have it) will be easier to handle.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12662

To: michalsrb, #ktexteditor
Cc: cullmann, ngraham, brauch, #frameworks, michaelh, kevinapavew, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180503/2fc779b5/attachment.html>


More information about the Kde-frameworks-devel mailing list