D12388: Output device color curves correction

Vlad Zagorodniy noreply at phabricator.kde.org
Thu May 3 14:45:13 UTC 2018


zzag added inline comments.

INLINE COMMENTS

> outputconfiguration.cpp:180
> +        wl_array_init(dest);
> +        int memLength = sizeof(uint16_t) * origin.size();
> +        void *s = wl_array_add(dest, memLength);

You forgot `const`. :-D
Also, I would use `size_t` instead of `int`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180503/36f243ac/attachment.html>


More information about the Kde-frameworks-devel mailing list