D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

Christophe Giboudeaux noreply at phabricator.kde.org
Thu May 3 08:19:06 UTC 2018


cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:68
>  
> -find_package(Phonon4Qt5 4.6.60 REQUIRED NO_MODULE)
> +find_package(Phonon4Qt5 4.6.60 OPTIONAL_COMPONENTS NO_MODULE)
>  set_package_properties(Phonon4Qt5 PROPERTIES

there are no component, why do you use this keyword ? removing 'REQUIRED' was enough

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D12674

To: tundracomp
Cc: cgiboudeaux, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180503/006a4179/attachment.html>


More information about the Kde-frameworks-devel mailing list