D12388: Output device color curves correction

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Please increase the versions.

INLINE COMMENTS

> output-management.xml:82
>  
>  <interface name="org_kde_kwin_outputconfiguration" version="1">
>      <description summary="list connected, but disabled outputs">

please increment version

> output-management.xml:142
>  
> +    <request name="colorcurves">
> +        <description summary="set output color curves">

since is missing

> output-management.xml:142
>  
> +    <request name="colorcurves">
> +        <description summary="set output color curves">

you cannot add requests in between, a new request must be the last.

> outputdevice.xml:32
>  
>  <interface name="org_kde_kwin_outputdevice" version="1">
>      <description summary="compositor output region">

version needs incrementation

> outputdevice.xml:179
>  
> +    <event name="colorcurves">
> +        <description summary="output color curves">

you cannot add events in between, new one needs to be last.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180502/b72b51dd/attachment.html>