D12648: Update mount point after mount operations

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed May 2 16:44:45 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> udisksstorageaccess.cpp:170
> +            m_device->invalidateCache();
>              m_device->broadcastActionDone("setup");
>  

This replaces one race condition with another (less likely) one. There is no guarantee the property is already updated when checkAccessibility is called.

The correct approach would be to defer until the propertiesChanged signal arrives and broadcast the "setup done" afterwards.

A different, but more intrusive approach would be to defer any check for the "acessible" property on the caller side, waiting for the accessibilityChanged signal.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D12648

To: davidedmundson, #plasma, broulik, mart
Cc: bruns, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180502/81f02974/attachment.html>


More information about the Kde-frameworks-devel mailing list