D12438: Fix PlasmaCalendar widget to not mark days with minor events

David Edmundson noreply at phabricator.kde.org
Wed May 2 12:15:23 UTC 2018


davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> DayDelegate.qml:105
>      Loader {
> -        active: model.containsEventItems !== undefined && model.containsEventItems
> +        active: model.containsMajorEventItems !== undefined && model.containsMajorEventItems
>          anchors.bottom: parent.bottom

surely this should be model !== undefined && model.contains

otherwise we're doing a filter twice.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixdisplayofminorevents

REVISION DETAIL
  https://phabricator.kde.org/D12438

To: kossebau, #plasma, broulik, davidedmundson
Cc: davidedmundson, broulik, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180502/6dd3c95a/attachment.html>


More information about the Kde-frameworks-devel mailing list